feature: add scrapeClass to VMAgent, VMServiceScrape, VMPodScrape, VMProbe #1549
Conversation
endesapt
requested review from
AndrewChubatiuk,
Haleygo and
f41gh7
as code owners
|
now i added scrapeClass only for ServiceScrape to get some feedback on my implementation in case this featured is not planned, my code is not ideal and i need to rethink it, or my help is not required. If everything is alright, i will add scrapeClass for the remaining resources |
|
I see that you self-assigned this task? Do you want us to work together or will u take this feature from here ? I would like to work on this if its not urgent and i am not against working together. It would be great if you tell your intentions so that there is no confusion. |
|
hey @endesapt |
|
Thats great, then i will add simillar functionality to other components. |
I'll create a small follow up and add missing APIs. |
|
Thats great, thanks for your fast responce! |
3 participants
Fixes: #1531
Prometheus Operator introduced scrapeClass to standardize common configurations such as relabeling rules, TLS certificates, and authentication. This PR is created to provide compatibility with Prometheus resources by adding scrapeClassName to VMServiceScrape, VMPodScrape, VMProbe, VMScrapeConfig and scrapeClasses to VMAgent that is similar to scrapeClasses of Prometheus CRD.